Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow null values inside enum property. #306

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Conversation

rtician
Copy link
Contributor

@rtician rtician commented Jun 15, 2021

As described in the docs null values are allowed inside enums. This PR fixed the lint error when you have nullable enums.

@CLAassistant
Copy link

CLAassistant commented Jun 15, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #306 (349681b) into main (6ddfac5) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 349681b differs from pull request most recent head 44453f2. Consider uploading reports for the commit 44453f2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files          73       73           
  Lines        2377     2377           
  Branches      605      605           
=======================================
  Hits         2187     2187           
  Misses        157      157           
  Partials       33       33           
Impacted Files Coverage Δ
...validation/2and3/semantic-validators/walker-ibm.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ddfac5...44453f2. Read the comment docs.

@barrett-schonefeld barrett-schonefeld changed the title Fixed null values inside enum property. fix: allow null values inside enum property. Jun 16, 2021
Copy link
Contributor

@barrett-schonefeld barrett-schonefeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The work looks good!

I updated the PR title to follow Angular commit style (i.e. fix: ...).

@rtician
Copy link
Contributor Author

rtician commented Jun 16, 2021

Thanks. Any chance to release a new version with this fix?

@dpopp07 dpopp07 merged commit cbe6269 into IBM:main Jun 16, 2021
ibm-devx-sdk pushed a commit that referenced this pull request Jun 16, 2021
## [0.46.1](v0.46.0...v0.46.1) (2021-06-16)

### Bug Fixes

* allow null values inside enum property ([#306](#306)) ([cbe6269](cbe6269))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.46.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants